Group Migration: Don't bump to top of list if we're not in group

Co-authored-by: Scott Nonnenberg <scott@signal.org>
signalapp · Mar 2, 2022 · 6859ccd · 6859ccd
1 parent d45a52b
commit 6859ccd
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ts/groups.ts b/ts/groups.ts
@@ -2662,11 +2662,11 @@ async function updateGroup(
   const startingRevision = conversation.get('revision');
   const endingRevision = newAttributes.revision;
 
-  const isInitialDataFetch =
-    !isNumber(startingRevision) && isNumber(endingRevision);
   const isInGroup = !updates.newAttributes.left;
+  const isInitialDataFetch =
+    isInGroup && !isNumber(startingRevision) && isNumber(endingRevision);
   const justJoinedGroup =
-    !conversation.hasMember(ourUuid.toString()) && isInGroup;
+    isInGroup && !conversation.hasMember(ourUuid.toString());
 
   // Ensure that all generated messages are ordered properly.
   // Before the provided timestamp so update messages appear before the