Only accept 'you left group' messages when group blocked

signalapp · Sep 17, 2018 · 814b9cf · 814b9cf
1 parent c2e0ec5
commit 814b9cf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/js/background.js b/js/background.js
@@ -920,9 +920,9 @@
       updates.left = true;
     }
 
-    if (details.blocked === true) {
+    if (details.blocked) {
       storage.addBlockedGroup(id);
-    } else if (details.blocked === false) {
+    } else {
       storage.removeBlockedGroup(id);
     }
 

diff --git a/libtextsecure/message_receiver.js b/libtextsecure/message_receiver.js
@@ -730,9 +730,12 @@ MessageReceiver.prototype.extend({
         const groupId = message.group && message.group.id;
         const isBlocked = this.isGroupBlocked(groupId);
         const isMe = envelope.source === textsecure.storage.user.getNumber();
-        const hasGroupMetadata = Boolean(message.group);
+        const isLeavingGroup = Boolean(
+          message.group &&
+            message.group.type === textsecure.protobuf.GroupContext.Type.QUIT
+        );
 
-        if (groupId && isBlocked && !(isMe && hasGroupMetadata)) {
+        if (groupId && isBlocked && !(isMe && isLeavingGroup)) {
           window.log.warn(
             `Message ${this.getEnvelopeId(
               envelope
@@ -768,9 +771,12 @@ MessageReceiver.prototype.extend({
         const groupId = message.group && message.group.id;
         const isBlocked = this.isGroupBlocked(groupId);
         const isMe = envelope.source === textsecure.storage.user.getNumber();
-        const hasGroupMetadata = Boolean(message.group);
+        const isLeavingGroup = Boolean(
+          message.group &&
+            message.group.type === textsecure.protobuf.GroupContext.Type.QUIT
+        );
 
-        if (groupId && isBlocked && !(isMe && hasGroupMetadata)) {
+        if (groupId && isBlocked && !(isMe && isLeavingGroup)) {
           window.log.warn(
             `Message ${this.getEnvelopeId(
               envelope