Allow quotes to be removed when editing a message

Co-authored-by: Scott Nonnenberg <scott@signal.org>
signalapp · Feb 29, 2024 · 8cbf91d · 8cbf91d
1 parent 5579c4f
commit 8cbf91d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/ts/components/CompositionArea.tsx b/ts/components/CompositionArea.tsx
@@ -930,13 +930,9 @@ export function CompositionArea({
                   ? () => scrollToMessage(conversationId, quotedMessageId)
                   : undefined
               }
-              onClose={
-                draftEditMessage
-                  ? undefined
-                  : () => {
-                      setQuoteByMessageId(conversationId, undefined);
-                    }
-              }
+              onClose={() => {
+                setQuoteByMessageId(conversationId, undefined);
+              }}
             />
           </div>
         )}

diff --git a/ts/state/ducks/composer.ts b/ts/state/ducks/composer.ts
@@ -749,7 +749,18 @@ export function setQuoteByMessageId(
     }
 
     const draftEditMessage = conversation.get('draftEditMessage');
-    if (draftEditMessage) {
+    // We can remove quotes, but we can't add them
+    if (draftEditMessage && messageId) {
+      return;
+    }
+    if (draftEditMessage && draftEditMessage.quote) {
+      conversation.set({
+        draftEditMessage: {
+          ...draftEditMessage,
+          quote: undefined,
+        },
+      });
+      dispatch(setComposerFocus(conversation.id));
       return;
     }