Skip to content

Commit

Permalink
Prevent new BrowserWindows from being created
Browse files Browse the repository at this point in the history
  • Loading branch information
scottnonnenberg-signal committed May 23, 2018
1 parent 559b215 commit 96bbc9d
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,9 @@ function createWindow() {

captureClicks(mainWindow);

mainWindow.webContents.on('will-navigate', e => {
mainWindow.webContents.on('will-navigate', event => {
logger.info('will-navigate');
e.preventDefault();
event.preventDefault();
});

// Emitted when the window is about to be closed.
Expand Down Expand Up @@ -523,11 +523,14 @@ app.on('activate', () => {
}
});

// Defense in depth. We never intend to open webviews, so this prevents it completely.
app.on('web-contents-created', (createEvent, win) => {
win.on('will-attach-webview', attachEvent => {
// Defense in depth. We never intend to open webviews or windows. Prevent it completely.
app.on('web-contents-created', (createEvent, contents) => {
contents.on('will-attach-webview', attachEvent => {
attachEvent.preventDefault();
});
contents.on('new-window', newEvent => {
newEvent.preventDefault();
});
});

ipc.on('set-badge-count', (event, count) => {
Expand Down

0 comments on commit 96bbc9d

Please sign in to comment.