Add an option to play audio notifications

signalapp · Feb 2, 2017 · bda0430 · bda0430
1 parent b9c8b4a
commit bda0430
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 0 deletions.
diff --git a/_locales/en/messages.json b/_locales/en/messages.json
@@ -453,6 +453,10 @@
         }
       }
     },
+    "audioNotificationDescription": {
+      "message": "Play audio notification",
+      "description": "Description for audio notification setting"
+    },
     "safetyNumbersSettingHeader": {
       "message": "Safety numbers approval",
       "description": "Header for safety numbers setting"

diff --git a/audio/NewMessage.mp3 b/audio/NewMessage.mp3
diff --git a/background.html b/background.html
@@ -463,6 +463,11 @@ <h3>{{ notifications }}</h3>
           <label for='notification-setting-off'>{{ disableNotifications }} </label>
         </div>
       </div>
+      <br />
+      <div class='audio-notification-setting'>
+        <input type='checkbox' name='audio-notification' id='audio-notification'/>
+        <label for='audio-notification'>{{ audioNotificationDescription }}</label>
+      </div>
       <hr>
       <div class='safety-numbers-settings'>
         <h3>{{ safetyNumbersSettingHeader }}</h3>

diff --git a/js/notifications.js b/js/notifications.js
@@ -12,6 +12,8 @@
         MESSAGE : 'message'
     };
 
+    var sound = new Audio('/audio/NewMessage.mp3');
+
     Whisper.Notifications = new (Backbone.Collection.extend({
         initialize: function() {
             this.on('add', _.debounce(this.update.bind(this), 1000));
@@ -35,6 +37,11 @@
             if (this.length === 0) {
                 return;
             }
+            var audioNotification = storage.get('audio-notification') || false;
+            if (audioNotification) {
+                sound.play();
+            }
+
             var setting = storage.get('notification-setting') || 'message';
             if (setting === SETTINGS.OFF) {
                 return;

diff --git a/js/views/settings_view.js b/js/views/settings_view.js
@@ -59,6 +59,11 @@
                 defaultValue: 'android',
                 name: 'theme-setting'
             });
+            new CheckboxView({
+                el: this.$('.audio-notification-setting'),
+                defaultValue: false,
+                name: 'audio-notification'
+            });
             new CheckboxView({
                 el: this.$('.safety-numbers-settings'),
                 defaultValue: true,
@@ -84,6 +89,7 @@
               nameOnly: i18n('nameOnly'),
               safetyNumbersSettingDescription: i18n('safetyNumbersSettingDescription'),
               safetyNumbersSettingHeader: i18n('safetyNumbersSettingHeader'),
+              audioNotificationDescription: i18n('audioNotificationDescription'),
               themeAndroidDark: i18n('themeAndroidDark'),
             };
         }