Contact Sync: Consider undefined value as a disabled expire timer

Co-authored-by: Scott Nonnenberg <scott@signal.org>
signalapp · Sep 1, 2022 · cf3060e · cf3060e
1 parent fd45d9b
commit cf3060e
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/ts/services/contactSync.ts b/ts/services/contactSync.ts
@@ -60,17 +60,13 @@ async function updateConversationFromContactSync(
   }
 
   // expireTimer isn't in Storage Service so we have to rely on contact sync.
-  const { expireTimer } = details;
-  const isValidExpireTimer = typeof expireTimer === 'number';
-  if (isValidExpireTimer) {
-    await conversation.updateExpirationTimer(expireTimer, {
-      source: window.ConversationController.getOurConversationId(),
-      receivedAt: receivedAtCounter,
-      fromSync: true,
-      isInitialSync,
-      reason: 'contact sync',
-    });
-  }
+  await conversation.updateExpirationTimer(details.expireTimer, {
+    source: window.ConversationController.getOurConversationId(),
+    receivedAt: receivedAtCounter,
+    fromSync: true,
+    isInitialSync,
+    reason: 'contact sync',
+  });
 
   window.Whisper.events.trigger('incrementProgress');
 }