Pass go headers through in updater/differential

signalapp · Mar 2, 2022 · da7a76e · da7a76e
1 parent 637b67d
commit da7a76e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/ts/test-node/updater/differential_test.ts b/ts/test-node/updater/differential_test.ts
@@ -76,6 +76,12 @@ describe('updater/differential', () => {
 
     beforeEach(callback => {
       server = http.createServer(async (req, res) => {
+        if (!req.headers['user-agent']?.includes('Signal-Desktop')) {
+          res.writeHead(403);
+          res.end(`Invalid user agent: "${req.headers['user-agent']}"`);
+          return;
+        }
+
         const file = req.url?.slice(1) ?? '';
         if (!allowedFiles.has(file)) {
           res.writeHead(404);

diff --git a/ts/updater/differential.ts b/ts/updater/differential.ts
@@ -350,9 +350,11 @@ export async function downloadRanges(
     diffByRange.set(`${readOffset}-${readOffset + size - 1}`, diff);
   }
 
+  const gotOptions = getGotOptions();
   const stream = got.stream(`${url}`, {
-    ...getGotOptions(),
+    ...gotOptions,
     headers: {
+      ...gotOptions.headers,
       range: `bytes=${Array.from(diffByRange.keys()).join(',')}`,
     },
   });