Message.sendSyncMessage: properly handle falsey id field

signalapp · Jul 21, 2021 · e94eaf0 · e94eaf0
1 parent 6893bbe
commit e94eaf0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ts/models/messages.ts b/ts/models/messages.ts
@@ -1851,7 +1851,9 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
           isUpdate,
           options: sendOptions,
         }),
-        { messageIds: [this.id], sendType: 'sentSync' }
+        // Note: in some situations, for doNotSave messages, the message has no
+        //   id, so we provide an empty array here.
+        { messageIds: this.id ? [this.id] : [], sendType: 'sentSync' }
       ).then(async result => {
         let newSendStateByConversationId: undefined | SendStateByConversationId;
         const sendStateByConversationId =