Disable auto-download of updates on Linux

Co-authored-by: Josh Perez <60019601+josh-signal@users.noreply.github.com>
signalapp · Aug 23, 2021 · ece6e09 · ece6e09
1 parent 96b9992
commit ece6e09
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 9 deletions.
diff --git a/ts/components/Preferences.stories.tsx b/ts/components/Preferences.stories.tsx
@@ -118,6 +118,7 @@ const createProps = (): PropsType => ({
   ),
 
   isAudioNotificationsSupported: true,
+  isAutoDownloadUpdatesSupported: true,
   isAutoLaunchSupported: true,
   isHideMenuBarSupported: true,
   isNotificationAttentionSupported: true,

diff --git a/ts/components/Preferences.tsx b/ts/components/Preferences.tsx
@@ -96,6 +96,7 @@ export type PropsType = {
 
   // Limited support features
   isAudioNotificationsSupported: boolean;
+  isAutoDownloadUpdatesSupported: boolean;
   isAutoLaunchSupported: boolean;
   isHideMenuBarSupported: boolean;
   isNotificationAttentionSupported: boolean;
@@ -184,6 +185,7 @@ export const Preferences = ({
   i18n,
   initialSpellCheckSetting,
   isAudioNotificationsSupported,
+  isAutoDownloadUpdatesSupported,
   isAutoLaunchSupported,
   isHideMenuBarSupported,
   isPhoneNumberSharingSupported,
@@ -344,15 +346,17 @@ export const Preferences = ({
             onChange={onMediaCameraPermissionsChange}
           />
         </SettingsRow>
-        <SettingsRow title={i18n('Preferences--updates')}>
-          <Checkbox
-            checked={hasAutoDownloadUpdate}
-            label={i18n('Preferences__download-update')}
-            moduleClassName="Preferences__checkbox"
-            name="autoDownloadUpdate"
-            onChange={onAutoDownloadUpdateChange}
-          />
-        </SettingsRow>
+        {isAutoDownloadUpdatesSupported && (
+          <SettingsRow title={i18n('Preferences--updates')}>
+            <Checkbox
+              checked={hasAutoDownloadUpdate}
+              label={i18n('Preferences__download-update')}
+              moduleClassName="Preferences__checkbox"
+              name="autoDownloadUpdate"
+              onChange={onAutoDownloadUpdateChange}
+            />
+          </SettingsRow>
+        )}
       </>
     );
   } else if (page === Page.Appearance) {

diff --git a/ts/types/Settings.ts b/ts/types/Settings.ts
@@ -58,3 +58,6 @@ export const getTitleBarVisibility = (): TitleBarVisibility =>
 export const isSystemTraySupported = (appVersion: string): boolean =>
   // We eventually want to support Linux in production.
   OS.isWindows() || (OS.isLinux() && !isProduction(appVersion));
+
+export const isAutoDownloadUpdatesSupported = (): boolean =>
+  OS.isWindows() || OS.isMacOS();
diff --git a/ts/windows/settings/preload.ts b/ts/windows/settings/preload.ts
@@ -305,6 +305,7 @@ async function renderPreferences() {
 
     // Limited support features
     isAudioNotificationsSupported: Settings.isAudioNotificationSupported(),
+    isAutoDownloadUpdatesSupported: Settings.isAutoDownloadUpdatesSupported(),
     isAutoLaunchSupported: Settings.isAutoLaunchSupported(),
     isHideMenuBarSupported: Settings.isHideMenuBarSupported(),
     isNotificationAttentionSupported: Settings.isDrawAttentionSupported(),