Skip to content

Commit

Permalink
Two fixes for linux
Browse files Browse the repository at this point in the history
* Linux: Change name of .desktop file to work around xdg-settings
* Reintroduce flashFrame on Linux, new --disable-flash-frame param
  • Loading branch information
scottnonnenberg-signal committed Oct 10, 2019
1 parent 2e2c5eb commit f790694
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
11 changes: 10 additions & 1 deletion main.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ let tray = null;
const startInTray = process.argv.some(arg => arg === '--start-in-tray');
const usingTrayIcon =
startInTray || process.argv.some(arg => arg === '--use-tray-icon');
const disableFlashFrame =
startInTray || process.argv.some(arg => arg === '--disable-flash-frame');

const config = require('./app/config');

Expand Down Expand Up @@ -906,7 +908,14 @@ ipc.on('add-setup-menu-items', () => {
});

ipc.on('draw-attention', () => {
if (process.platform === 'win32' && mainWindow) {
if (!mainWindow) {
return;
}
if (disableFlashFrame) {
return;
}

if (process.platform === 'win32' || process.platform === 'linux') {
mainWindow.flashFrame(true);
}
});
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "signal-desktop",
"productName": "Signal",
"description": "Private messaging from your desktop",
"desktopName": "signal-desktop.desktop",
"desktopName": "signal.desktop",

This comment has been minimized.

Copy link
@igorkulman

igorkulman Dec 3, 2019

This breaks badges on Ubuntu.

This comment has been minimized.

Copy link
@scottnonnenberg-signal

scottnonnenberg-signal Dec 3, 2019

Author Contributor

How so?

This comment has been minimized.

Copy link
@igorkulman

igorkulman Dec 3, 2019

See #3387 (comment)

I am not 100% sure as I am not able to build the repo with change but it makes sense according to the comment and the fact that it stopped working for me only recently after update to a version that should include this change.

"repository": "https://github.com/signalapp/Signal-Desktop.git",
"version": "1.27.3-beta.2",
"license": "GPL-3.0",
Expand Down

0 comments on commit f790694

Please sign in to comment.