Exception while processing prekey response

[liliakai]

When requesting prekeys for recipient from the server, the response comes back successful, but saveDeviceObject throws "unsure of how to jsonify object of type undefined", which is caught and converted into "Failed to retreive new device keys for number".

I think the undefined is coming from response[i].registrationId on L486 of helpers.js.

[TheBlueMatt]

Cant reproduce on master, can you double-check and/or fix?

[liliakai]

definitely an issue with jsonifying undefined registration ids. i can only send messages if i delete them. will dig in a little more later tonight.

diff --git a/js/helpers.js b/js/helpers.js
index 18c4aca..ce98442 100644
--- a/js/helpers.js
+++ b/js/helpers.js
@@ -480,8 +480,7 @@ function getKeysForNumber(number) {
                 encodedNumber: number + "." + response[i].deviceId,
                 identityKey: response[i].identityKey,
                 publicKey: response[i].publicKey,
-                preKeyId: response[i].keyId,
-                registrationId: response[i].registrationId
+                preKeyId: response[i].keyId
             });
         }
         return response[0].identityKey;
@@ -500,7 +499,6 @@ function sendMessageToDevices(number, deviceObjectList, message, success_callbac
             jsonData[i] = {
                 type: encryptedMsg.type,
                 destination: deviceObjectList[i].encodedNumber,
-                destinationRegistrationId: deviceObjectList[i].registrationId,
                 body: encryptedMsg.body,
                 timestamp: new Date().getTime()
             };