Fix cropped message reaction icons #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylesheets/_modules.scss
Outdated
| @@ -11476,15 +11476,15 @@ $contact-modal-padding: 18px; | |||
| } | |||
|
|
|||
| /* Spec: container < 437px */ | |||
| @media (min-width: 0px) and (max-width: 799px) { | |||
| @media (min-width: 0px) and (max-width: 834px) { | |||
| .module-message { | |||
| // Add 2px for 1px border | |||
| max-width: 302px; | |||
| } | |||
| } | |||
|
|
|||
| /* Spec: container > 438px and container < 593px */ | |||
There was a problem hiding this comment.
Do these comments need to change?
There was a problem hiding this comment.
Perhaps they do have to change. I don't understand what they're referring to. If that Spec: container < 437 px refers to the module-timeline__message-container, then they're not up to date.
Should I update them?
There was a problem hiding this comment.
I'm thinking it's this container as mentioned before
Before my commits the values in the comments didn't match that container's width. I've updated them now to its width anyway.
|
Just pulled down the changes which look good—all that's needed is updates to those comments and then we should be good to go. |
EvanHahn-Signal
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
developmentbranchyarn readyrun passes successfully (more about tests here)Description
Reduced the min-width/increased the max-width of media queries to switch sooner from reaction icons for messages to a "more" menu.
Smallest media query
next smallest media query
