Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkboxes dark in dark theme #6345

Merged
merged 1 commit into from Mar 29, 2023
Merged

Make checkboxes dark in dark theme #6345

merged 1 commit into from Mar 29, 2023

Conversation

rakleed
Copy link
Contributor

@rakleed rakleed commented Mar 26, 2023

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A yarn ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Make checkboxes dark in a dark theme. I tested it with Signal Desktop for macOS.

Before:

Screenshot 2022-05-27 at 02 23 33

After:

Screenshot 2022-05-27 at 02 23 48

@josh-signal
Copy link
Contributor

@rakleed can you run prettier on the files?

@rakleed
Copy link
Contributor Author

rakleed commented Mar 27, 2023

If I format a file locally using the Prettier plugin in WebStorm, then it does not change in any way. And when I run yarn test I get the same error as in GitHub Actions.

@josh-signal
Copy link
Contributor

run yarn format

@rakleed
Copy link
Contributor Author

rakleed commented Mar 28, 2023

Done.

Copy link
Contributor

@josh-signal josh-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It'll be on the next release.

@josh-signal josh-signal merged commit 6dab8c7 into signalapp:main Mar 29, 2023
7 of 8 checks passed
@rakleed rakleed deleted the patch-1 branch March 29, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants