Always allow 'Note To Self' deletions regardless of time #6689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there - before I look at the code, have you looked to see how the other two clients behave in this situation? We strive for consistency across all three clients. |
|
Hey, yeah I have. This issue is actually addressing how the desktop client isn't consistent with the other clients. Android will let you remove any "Note To Self" messages regardless of how long ago they were sent. while all other conversations are limited to a day. Thanks! |
|
@lamemakes Thanks for your work on this - it will be included in our next releases! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
Fixes #6682. This ensures that 'Note To Self' messages can be deleted from all devices at any time as opposed to being constrained to the one day time box as messages to other Signal users are. This reflects the behavior that is seen on other Signal clients.
This fix was manually tested on a Fedora 38 workstation. I attempted to remove old messages in 'Note To Self', ensured the proper prompts were given, and that these message deletions were reflected on my Android Signal client. I also checked with conversations to other Signal users and ensured that the previous functionality was unchanged.
Let me know if there's any critiques, cheers!