Save current image from the gallery view by pressing 's', 'd', or 'Enter' #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pelya, thanks for your contribution. I spoke with our design team and we would be happy with this change if we modified it to be "cmd + s" (on macOS, else "ctrl + s") shortcut, rather than the three keys you have now. Would you be interested in making that change? |
pelya
force-pushed
the
save-gallery-image-with-enter
branch
from
52ce24a
to
ef67a98
Compare
|
I've changed key shortcut to Ctrl-S |
| @@ -211,10 +213,16 @@ export function Lightbox({ | |||
| onNext(event); | |||
| break; | |||
|
|
|||
| case 's': | |||
| if (isMacOS ? event.metaKey : event.ctrlKey) { | |||
There was a problem hiding this comment.
do you mind using the isCmdOrCtrl utility function we have?
trevor-signal
added
the
PR: Needs CLA
Thanks! One small comment, and do you mind signing the CLA? That's required for outside contributions. |
|
I've signed CLA with my Github account. The CI script won't update the
checkbox, I probably need to make another push request.
I'll switch my code to use isCmdOrCtrl function in a few days. Feel free
to push my commit as-is meanwhile, there are like ten other places where
this function should be used, it would make sense to create a separate
commit to refactor the rest of the codebase.
…On Wed, 20 Dec 2023, 17:58 trevor-signal, ***@***.***> wrote:
I've changed key shortcut to Ctrl-S
Thanks! One small comment, and do you mind signing the CLA? That's
required for outside contributions.
—
Reply to this email directly, view it on GitHub
<#6724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABF5QCQND3TL2WP4DQHY4LYKMDLNAVCNFSM6AAAAABAZRAU42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUG4ZTINBWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
trevor-signal
removed
the
PR: Needs CLA
|
Thanks, I've updated it and merged into our private repo. This will be released early next year! Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
This commit will allow to save images from a gallery view by pressing Enter, 's', or 'd' keys.
To test: