Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify export protocol #131

Closed
rauno56 opened this issue Sep 27, 2021 · 3 comments
Closed

Specify export protocol #131

rauno56 opened this issue Sep 27, 2021 · 3 comments

Comments

@rauno56
Copy link

rauno56 commented Sep 27, 2021

Is your feature request related to a problem? Please describe.
We currently spec the distros to use OTLP, but are not saying whether the protocol should be over HTTP or gRPC. The latest version of the Collector receives those on different ports. There has been an effort to consolidate that.
Would we want to spec that?

Describe the solution you'd like
Since our ingest only supports OTLP/HTTP it makes sense to prefer that over gRPC and default to 4318. Otherwise, we'd need to provide additional configuration and complexity to switch between collectorless and "collectorful" usecases.

Describe alternatives you've considered
An alternative would be to default to OTLP/gRPC(currently on port 4317 on the Collector), which is what Python and Java does, but that means additional configuration burden when switching to collectorless setup.

@pellared
Copy link
Contributor

Would we want to spec that?

Yes 👍 It would avoid confusion whatever we agree on.

@pellared
Copy link
Contributor

pellared commented Sep 27, 2021

@rauno56 Can I assign this issue to you and can you create a PR later?

@rauno56
Copy link
Author

rauno56 commented Oct 1, 2021

Solved in #132!

@rauno56 rauno56 closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants