Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty values not handled safely #29

Closed
tkurki opened this issue Jul 15, 2015 · 1 comment
Closed

Empty values not handled safely #29

tkurki opened this issue Jul 15, 2015 · 1 comment

Comments

@tkurki
Copy link
Member

tkurki commented Jul 15, 2015

For example:

$IIMWV,,,,*4C
TypeError: Cannot read property 'toUpperCase' of undefined
    at null._decoder (/home/pi/signalk-server-node/node_modules/nmea0183-signalk/codecs/MWV.js:59:14)
    at NMEA0183.decode (/home/pi/signalk-server-node/node_modules/nmea0183-signalk/lib/NMEA0183.js:236:24)
    at Parser._decode (/home/pi/signalk-server-node/node_modules/nmea0183-signalk/lib/index.js:107:44)
    at /home/pi/signalk-server-node/node_modules/nmea0183-signalk/lib/index.js:151:22
@fabdrol
Copy link
Member

fabdrol commented Jul 16, 2015

@tkurki I'll have a look at this asap, I'll let you know. I haven't encountered this one before, even though I have tested with empty values. Could be a regression in a newer codec.

@tkurki tkurki mentioned this issue Jul 25, 2015
Merged
@tkurki tkurki closed this as completed in #31 Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabdrol @tkurki