-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade to Bootstrap 5. #925
Open
darkobits
wants to merge
8
commits into
master
Choose a base branch
from
bootstrap-5
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkobits
force-pushed
the
bootstrap-5
branch
6 times, most recently
from
March 21, 2024 10:21
85a3d5e
to
0bcd42c
Compare
darkobits
force-pushed
the
bootstrap-5
branch
11 times, most recently
from
March 28, 2024 04:30
07fe119
to
ad84442
Compare
darkobits
force-pushed
the
bootstrap-5
branch
2 times, most recently
from
April 3, 2024 07:26
be50397
to
4bb6054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏗️ Migrate to Bootstrap 5
This PR upgrades the website from Bootstrap 4 to Bootstrap 5, resulting in a minor but much-needed UI refresh. This has also allowed us to remove a lot of our custom CSS. I've also done some general housekeeping, and added some extra goodies.
Major Changes
signalstickers.org
andsignal.org
.fontsource.org
instead of Google Fonts. This better aligns with our stance on privacy as Google does track end users when their fonts are downloaded. This also gives us version locking and a slight performance boost.react-switch
; Bootstrap 5 has a native component for this.prefers-color-scheme
selector to set the initial value for dark/light mode.Notable Changes in Bootstrap 5
For a full list of changes in version 5, check out the migration guide. Some noteworthy updates are:
left
andright
are nowstart
andend
respectively. (read more).form-row
and.form-group
have been dropped in favor of using grid classes for layout. This change allowed us to remove two layers of nested elements on each form control on our forms.Other Refactoring
original
,animated
, andeditorschoice
.async
, removing the need to explicitly callsetSubmitting
.status
to track when to show field errors and to store API errors.npm audit
with 0 vulnerabilities. 🔒🌎 A preview of these changes is available here.