improve performance by adding enabled flag to useWatcher
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/signavio/react-stick/2xio9lb4u |
- we only need to register the measuring callback if we actually have a `node` prop. - this reduced a lot of unnecessary computations that made applications with a lot of `Stick` components slow over time. Co-authored-by: Andreas Köberle <koeberle@gmail.com>
tzimmermann
force-pushed
the
fix/useWatcher-performance
branch
from
e7c9296
to
7cae622
Compare
frontendphil
approved these changes
Nov 6, 2020
|
🎉 This PR is included in version 4.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeprop.Stickcomponents slow over time.Here are two performance measurements, using no
nodeprop.This is the status quo: a lot of CPU usage and calculations going on, even there are no interactions with the page and no
nodeneeds to be measured:After our opmizations: almost no CPU usage any more in the idle state:
