Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less opinionated layout #15

Closed
pdrbrnd opened this issue Jan 31, 2019 · 1 comment
Closed

Less opinionated layout #15

pdrbrnd opened this issue Jan 31, 2019 · 1 comment
Labels

Comments

@pdrbrnd
Copy link
Member

pdrbrnd commented Jan 31, 2019

This package should allow for anyone to set the desired column layout. (e.g.: setting grid-template-columns). Isto also very strict with the values we provide via props. For instance, if the package allowed a className prop to set these values (grid-template-columns, grid-gap, etc.), I would have to make them !important to overwrite the inline styles.

We could argue that grid-gap can be given via props, but what about responsive values?

The great value here is the package's ability to set the row span of the children elements in a way that they'll stack together Pinterest style, but I see no point on forcing the column layout and gap with strict & unresponsive values.

@pdrbrnd pdrbrnd added enhancement New feature or request featured request labels Jan 31, 2019
@danilowoz
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants