Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow getAccountBalance for Burn Account (or return burnt SIGNA in getState) #739

Closed
ohager opened this issue Apr 22, 2023 · 2 comments
Closed
Assignees
Labels
API Issues related to the Node's API

Comments

@ohager
Copy link
Member

ohager commented Apr 22, 2023

Problem

as for the total supply reported to CMC we use totalMinedNQT from GET /api?requestType=getState, but would be good to report a value where burnt SIGNA is being subtracted from. Unfortunately, the endpoints getAccount and getAccountBalance do not allow 0 account.

Solutions

  1. add burntNQT to getState method
  2. allow getAccount and/or getAccountBalance for Burn Account

Ideally, both makes sense

@ohager ohager added the API Issues related to the Node's API label Apr 22, 2023
@frankTheTank72
Copy link
Member

frankTheTank72 commented Apr 22, 2023

maybe also add totalSupply into the getState which already does the work minted - burned

@jjos2372
Copy link

Added some more stuff to getState, below for testnet:

  "totalMinedNQT": 199258764100000000,
  "totalBurntNQT": 55409445190405,
  "circulatingSupplyNQT": 199203354654809600,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to the Node's API
Projects
None yet
Development

No branches or pull requests

3 participants