Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support edit files #179

Merged
merged 1 commit into from
Feb 20, 2023
Merged

feat: support edit files #179

merged 1 commit into from
Feb 20, 2023

Conversation

sigoden
Copy link
Owner

@sigoden sigoden commented Feb 20, 2023

close #172

@sigoden sigoden merged commit dd69734 into main Feb 20, 2023
@sigoden sigoden deleted the feat-editor branch February 20, 2023 14:50
@ItsNoted
Copy link

Thanks. When will the commit be pushed to the docker image?

@sigoden
Copy link
Owner Author

sigoden commented Feb 20, 2023

Within this month

@ItsNoted
Copy link

ItsNoted commented Mar 4, 2023

It lets me click the edit icon but will not let me save anything I add to the files.

@sigoden
Copy link
Owner Author

sigoden commented Mar 5, 2023

I'm not sure about your problem.

After you modify the file, is the file not saved after clicking Save button in the upper right corner?

Doesn't the dufs log show something like PUT <file path> 201?
Did the changes not take effect after refreshing the page?
@ItsNoted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Edit files
2 participants
@sigoden @ItsNoted