Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview text file #300

Closed
vnghia opened this issue Nov 27, 2023 · 7 comments
Closed

Preview text file #300

vnghia opened this issue Nov 27, 2023 · 7 comments

Comments

@vnghia
Copy link

vnghia commented Nov 27, 2023

Specific Demand

Sometimes I want to have a way to view my configuration files (yml) without downloading it into my machine first.

Implement Suggestion

We've already had an edit panel inside dufs. I think we could just add an eye icon and when that button is clicked, we open the editor without allowing editing.

Thank you for a wonderful software and I can send a PR if you think this make sense.

@sigoden
Copy link
Owner

sigoden commented Nov 27, 2023

Putting configuration config.yaml under the dufs's serve path is dangerous. Strongly recommend users not to do this.

@vnghia
Copy link
Author

vnghia commented Nov 27, 2023

Ah no, not the config.yaml of dufs. I use dufs to browsing the content of several docker named volumes cause I don't want to go with the terminal. And of course, it is only accessible with a VPN.

Edit: For more context, I use some kind of Infra-as-Code to generate pretty much every configuration files in my docker stack. Sometime, thing does not work out as expected and I want to view what is wrong with my configuration file on some docker named volumes. I know I can click on edit button and not edit it. But I guess a view only button seems more reassuring.

@sigoden
Copy link
Owner

sigoden commented Nov 27, 2023

I misunderstood.
You can directly view the text file by clicking it's link.

image

@sigoden
Copy link
Owner

sigoden commented Nov 27, 2023

image

@vnghia
Copy link
Author

vnghia commented Nov 27, 2023

I guess it is browser specified. Because when I tried to do the same thing with firefox, it will download that file instead of showing previewing. It does show a preview for xml and json but not yaml

@sigoden
Copy link
Owner

sigoden commented Nov 27, 2023

#301 supports this feature.

@sigoden sigoden closed this as completed Nov 27, 2023
@vnghia
Copy link
Author

vnghia commented Nov 27, 2023

Thank you so much for this awesome software 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants