Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upload more than 100 files in directory #317

Merged
merged 1 commit into from Dec 11, 2023
Merged

fix: upload more than 100 files in directory #317

merged 1 commit into from Dec 11, 2023

Conversation

plantatorbob
Copy link
Contributor

This PR changes addFileEntries behaviour so that it attempts to call readEntries multiple times, until readEntries returns an empty array.
This allows addFileEntries to correctly handle large directories on Chromium-based browsers (readEntries only returns up to 100 entries per call).

Fixes #316.

@sigoden sigoden merged commit cd84dff into sigoden:main Dec 11, 2023
3 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If a directory with a large amount of files is uploaded, only 100 files are actually uploaded
2 participants
@plantatorbob @sigoden