Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUF: Support option to reference mirror during verification/signing #1289

Closed
haydentherapper opened this issue Jan 7, 2022 · 3 comments · Fixed by #1315
Closed

TUF: Support option to reference mirror during verification/signing #1289

haydentherapper opened this issue Jan 7, 2022 · 3 comments · Fixed by #1315
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

Currently, cosign initialize is the only way to update BYO TUF metadata. If the TUF metadata is out of date on verification/signing, then cosign will fetch the updated TUF metadata from the hosted GCS bucket.

One option would be to move mirror and root to global flags, so that these could be used with any cosign command. The TUF client would need to be refactored to look for these flags when updating TUF metadata.

#1288 improves UX for this issue, so that the flag values don't have to be passed with each invocation.

cc @asraa

@haydentherapper haydentherapper added the enhancement New feature or request label Jan 7, 2022
@asraa
Copy link
Contributor

asraa commented Jan 7, 2022

Just adding some more context:

then cosign will fetch the updated TUF metadata from the hosted GCS bucket.

This is because of the default fallback. It's kind of questionable on whether we want to fallback gracefully or fail when your cache is expired or corrupt

@haydentherapper
Copy link
Contributor Author

Adding support for this will also allow cosign to support BYO TUF with no disk writes (SIGSTORE_NO_CACHE), since the TUF client would use the mirror to fetch TUF metadata/targets, and then those would be persisted in-memory.

@rgerganov
Copy link
Contributor

It'd be also nice if cosign is keeping the mirror URL which is passed on cosign initialize and tries to update from it when the local cache has expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants