Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: image sign annotations from dev.cosignproject.cosign to dev.sigstore.cosign #1532

Open
Dentrax opened this issue Mar 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Dentrax
Copy link
Member

Dentrax commented Mar 2, 2022

Description

In layout/index.go and signature/layer.go we are using dev.cosignproject.cosign key. I think it would be nice to change these names as we are already using dev.sigstore.cosign for certkey, chainkey and BundleKey.

Migration

This would be breaking change. I'm not sure what is the right way to handle this, but the first thing I thought is that we can check for dev.cosignproject.cosign label at first and if not exist falling back to dev.sigstore.cosign for second check (or send 2 reqs concurrently) would solve the problem. (We can reverse the order after a few new version released) That would be a workaround because we are not pinning cosign's version in labels. That said, we do not know which version of cosign the user is using.

@dlorenc
Copy link
Member

dlorenc commented Mar 2, 2022

+1 for supporting both for some time.

I'm not sure we can make the change though without a major version bump, since signatures generated with one version need to validate in previous ones.

@Dentrax Dentrax mentioned this issue Jan 24, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants