New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosigned] glob matching is basic right now #1840

Closed

DennyHoang opened this issue May 4, 2022 · 1 comment · Fixed by #1842

Labels

Contributor

DennyHoang commented May 4, 2022 •

edited

Description
Currently, glob matching is just a prefix check allowing only trailing wildcarding *

This is an issue as glob patterns such as:

gcr.io images could have suffixes for regions such as us.gcr.io (*.gcr.io/image is not supported)
<dockerhub account>/image is not supported as it is resolved to index.docker.io/...

I would like to suggest improvement to:

allow multiple wildcarding (i.e *gcr.io/*)
maybe images without hosts should default to try to match with index.docker.io since that is what those images would resolve as far as I know

Related issue: #1834

The text was updated successfully, but these errors were encountered:

DennyHoang added the enhancement label

DennyHoang changed the title ~~[Cosigned] glob is basic right now~~ [Cosigned] glob matching is basic right now

Contributor Author

DennyHoang commented May 4, 2022

I will try to make a PR for this change

DennyHoang mentioned this issue

[Cosigned] Glob matching improvement #1842

Merged

dlorenc closed this as completed in #1842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment