Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--certificate or --cert? #1847

Closed
znewman01 opened this issue May 6, 2022 · 1 comment · Fixed by #1868
Closed

--certificate or --cert? #1847

znewman01 opened this issue May 6, 2022 · 1 comment · Fixed by #1868
Labels
bug Something isn't working

Comments

@znewman01
Copy link
Contributor

Let's sign something:

$ cosign sign-blob /dev/null --output-cert /tmp/null.crt
Error: unknown flag: --output-cert
main.go:52: error during command execution: unknown flag: --output-cert

Okay, must be "certificate":

$ cosign sign-blob /dev/null --output-certificate /tmp/null.crt
[...]

That worked! Now verify:

$ cosign verify-blob /dev/null --certificate /tmp/null.crt
Error: unknown flag: --certificate
main.go:52: error during command execution: unknown flag: --certificate

Wat.

$ cosign verify-blob /dev/null --cert /tmp/null.crt                                                                                
[...]

Oh okay ☹️


We should probably make --*-certificate the canonical flag name, and do what GNU CLIs do and accept unambiguous prefixes (if that's too big of a move in general, maybe just add aliases for these flags explicitly).

@znewman01 znewman01 added the bug Something isn't working label May 6, 2022
@haydentherapper
Copy link
Contributor

on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants