Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a reason why rekor pubkeys has to be ecdsa #2540

Closed
vaikas opened this issue Dec 13, 2022 · 2 comments
Closed

Is there a reason why rekor pubkeys has to be ecdsa #2540

vaikas opened this issue Dec 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Dec 13, 2022

Description

Just curious if there's a reason why this has to be explicitly ecdsa and not just crypto.publickey?
https://github.com/sigstore/cosign/blob/main/pkg/cosign/tlog.go#L56

I just know when I was working on some of the scaffolding things there was some future proofing work so just curious.
@asraa @haydentherapper
@vaikas vaikas added the enhancement New feature or request label Dec 13, 2022
@haydentherapper
Copy link
Contributor

Iirc it’s hardcoded into rekor, unless we’ve switched to the signer/verifier interface

@vaikas
Copy link
Contributor Author

vaikas commented Dec 13, 2022

Ack, thanks!

@vaikas vaikas closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haydentherapper @vaikas