Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shutdown behavior #1341

Closed
haydentherapper opened this issue Aug 31, 2023 · 0 comments · Fixed by #1342
Closed

Add Shutdown behavior #1341

haydentherapper opened this issue Aug 31, 2023 · 0 comments · Fixed by #1342
Assignees
@haydentherapper
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

Currently, the server does not listen for an interrupt, so a server restart may terminate ongoing connections. Golang HTTP servers provide a shutdown method to gracefully terminate, which we are currently not calling.

See https://pkg.go.dev/net/http#Server.Shutdown for an example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haydentherapper haydentherapper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gracefully shutdown HTTP, gRPC, and Prom servers haydentherapper/fulcio
1 participant
@haydentherapper