Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't request profile scope from IdPs in https://oauth2.sigstore.dev/auth #157

Closed
letmaik opened this issue Jul 30, 2021 · 4 comments
Closed

Comments

@letmaik
Copy link

letmaik commented Jul 30, 2021

For some reason, the OIDC proxy provider https://oauth2.sigstore.dev/auth requests profile scope against Google and Microsoft. It shouldn't do that, openid email is enough.

Side-note: Is this proxy provider going to stay? It seems like it would complicate the whole attestation story even more, see #80.

@dlorenc
Copy link
Member

dlorenc commented Aug 8, 2021

Thanks for the pointer! I think we need profile for GitHub, we'll have to check whether we can configure the scopes for each provider.

@bobcallaway is on vacation for another week, he's been evaluating whether we'll keep the proxy, move to another one, or remove it.

@bobcallaway
Copy link
Member

I've fixed the google scopes, but fixing the MSFT ones will require a code change.

And yes, you're correct that having a proxy provider does complicate the attestation story a bit, but it does have some benefits as well. As Dan noted, I'm working on a doc that will compare/contrast the alternatives here and will post it for community feedback shortly.

@bobcallaway
Copy link
Member

MSFT is now fixed as well at https://oauth2.sigstore.dev/auth

@lukehinds
Copy link
Member

can we close ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants