Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting multiple CTLogs #310

Closed
vaikas opened this issue Jan 4, 2022 · 3 comments
Closed

Consider supporting multiple CTLogs #310

vaikas opened this issue Jan 4, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Jan 4, 2022

Description
Currently we support one CTLog where SCT is then returned from. It might be useful in the future to support multiple ones. Besides the obvious need to modify code, just curious if we may want to consider at least allowing the API here:
https://github.com/sigstore/fulcio/blob/main/pkg/api/client.go#L31

Also copied here in case links shift:

type CertificateResponse struct {
	CertPEM  []byte
	ChainPEM []byte
	SCT      []byte
}

To be able to return multiple SCT, and we could further restrict the current api to say that it will only return 0 atm.

Brought this up 2022-01-04 meeting and it was deemed that we may want to look into this, from a quick look didn't see an issue, so here it is :)

There also has been some further discussion in the past so mayhaps we can gather those thoughts here, or pointers to them in case folks want to chime in / follow along.

@vaikas vaikas added the enhancement New feature or request label Jan 4, 2022
@haydentherapper
Copy link
Contributor

#507 will solve this since an SCT list will be embedded in certificates.

@vaikas
Copy link
Contributor Author

vaikas commented Apr 9, 2022

Nice!

@haydentherapper
Copy link
Contributor

Closing issue, as we now support embedding SCT lists in certificates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants