Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitsign doesn't support git config --global options #128

Closed
wlynch opened this issue Sep 1, 2022 · 1 comment · Fixed by #149
Closed

Gitsign doesn't support git config --global options #128

wlynch opened this issue Sep 1, 2022 · 1 comment · Fixed by #149
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wlynch
Copy link
Member

wlynch commented Sep 1, 2022

Description

From @mattmoor:

I did --global, does that not work?


My ~/.gitconfig has this at the end:
[gpg "x509"]
        program = gitsign
[gpg]
        format = x509
[commit]
        gpgsign = true
[gitsign]
        connectorID = https://accounts.google.com/
which looks right?

If I configure it in the local repo it works 

Root cause appears to be go-git/go-git#508 - we're losing the custom gitsign config options when the configs are merged. This would also affect options set with git config --system

Version

v0.3.0

@wlynch wlynch added the bug Something isn't working label Sep 1, 2022
@wlynch wlynch changed the title Gitsign doesn't support git config --global Gitsign doesn't support git config --global options Sep 1, 2022
@wlynch wlynch added the good first issue Good for newcomers label Sep 2, 2022
@wlynch
Copy link
Member Author

wlynch commented Sep 2, 2022

To work around this, we can likely just reimplement what go-git does and handle the merge for gitsign related fields ourselves - https://github.com/go-git/go-git/blob/bc1f419cebcf7505db31149fa459e9e3f8260e00/repository.go#L496-L522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant