Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 release #175

Open
2 of 10 tasks
laurentsimon opened this issue May 13, 2024 · 6 comments
Open
2 of 10 tasks

v1 release #175

laurentsimon opened this issue May 13, 2024 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented May 13, 2024

This is a proposal for v1 release.
Scope: support sigstore for path only (no in-memory path support). This requires to implement only a subset of #172:

# model.py
def sign(
      input: Path,
      sig: Path  = defaultSigPath(input),
      recompute_paths: []Path = None,
      ignored_paths: []Path = [".git"],
     ) -> None
    ...

def verify(
      input: Path,
      sig: Path  = defaultSigPath(input),
      verifier: Verifier = SigstoreVerifier(),
      ignored_paths: []Path = [".git"],
    ) -> bool

What needs to be done:

Simple

Medium

More work

We can add support for more features #172 without breaking backward compatibility

@laurentsimon laurentsimon added the enhancement New feature or request label May 13, 2024
@laurentsimon
Copy link
Collaborator Author

@mihaimaruseac what do you think of making these the prio for v1?

@mihaimaruseac
Copy link
Collaborator

I think anything that comes for the API are priority. So #172 , #111 (manifest), #140 (hash engine), #160 (incremental rehashing) are a must. As part of this, we will also need to clean-up BaseResult (#174).

Looking back, that's exactly the list you mentioned above.

@mihaimaruseac mihaimaruseac pinned this issue May 14, 2024
@mihaimaruseac mihaimaruseac added this to the V1 release milestone May 14, 2024
@mihaimaruseac
Copy link
Collaborator

I think #157 might also be good to have in the release

@laurentsimon
Copy link
Collaborator Author

I think #157 might also be good to have in the release

Good call. Added to the list. Thanks!

@mihaimaruseac
Copy link
Collaborator

Added all of them to a milestone too. But also added improvement issues there, so it's good to keep track of the important ones on this issue

@laurentsimon
Copy link
Collaborator Author

This was discussed in the SIG meeting of 12 June 24. We would like to also support private PKI for this release. (We don't need to support all possible features, and we'll add new ones without breaking backward compatibility)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants