Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to handle multiple Fulcio certs in the createctconfig. #292

Closed
vaikas opened this issue Aug 12, 2022 · 0 comments · Fixed by #352
Closed

Add ability to handle multiple Fulcio certs in the createctconfig. #292

vaikas opened this issue Aug 12, 2022 · 0 comments · Fixed by #352
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Aug 12, 2022

Description

As discussed in sigstore/fulcio#589 we should be able to handle rotation of Fulcio certs properly. This requires being able to add multiple Fulcio certs to be trusted by the CTLog.
I guess you just have to add certs here, currently we just add one.

This is the file that CTLog reads:
https://github.com/sigstore/scaffolding/blob/main/cmd/ctlog/createctconfig/main.go#L127

And here we create the secret containing the Fulcio cert to trust:
https://github.com/sigstore/scaffolding/blob/main/cmd/ctlog/createctconfig/main.go#L196

Which gets mounted here:
https://github.com/sigstore/scaffolding/blob/main/config/ctlog/ctlog/300-ctlog.yaml#L45

So, the tricky bit is that we don't want to just be append only :) So, have to think about how to add enough, but not too many of the certs and TBD how to remove them from here, once old Fulcio's have been turned down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant