Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kms: add 1password as a new KMS #1394

Open
Dentrax opened this issue Sep 8, 2023 · 1 comment
Open

kms: add 1password as a new KMS #1394

Dentrax opened this issue Sep 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Dentrax
Copy link
Member

Dentrax commented Sep 8, 2023

Description

We (@developer-guy) propose to add a brand-new KMS for 1password!

They provides an official connect-sdk-go package that we can use in the kms package. Implementation would quite easy by taking advantage of aforementioned library. Unfortunately, 1password does not support 1 generating ECDSA keys in-place. So we should generate it in-memory and upsert without writing to local filesystem.

Thank @wlynch for the idea! 2

/good-first-issue
/low-hanging-fruit

Footnotes

  1. https://1password.community/discussion/127230/i-18-support-for-ecdsa-keys

  2. https://sigstore.slack.com/archives/C03ETLNSA3Z/p1692195519374149?thread_ts=1692195049.385139&cid=C03ETLNSA3Z

@Dentrax Dentrax added the enhancement New feature or request label Sep 8, 2023
@haydentherapper
Copy link
Contributor

Hey, thanks for the suggestion. Per https://github.com/sigstore/sigstore/blob/main/POLICY.md#kms-providers, if there is significant community interest in this, then we would accept this. I'll leave this issue up for any discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants