You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a setup where I only upload a small percentage of my traces.
This means that for majority of my samples in a histogram there won't be a corresponding trace.
Current library implementation:
When presented with a new sample with no exemplar labels the library overrides the bucket's exemplar labels with an empty object essentially purging the existing exemplar
Example of metric after sample is published with an exemplar labels: example_duration_bucket{le="5"} 1 # {traceID="9899898"} 3.0005617 1708951967.457
Example of metric after sample is published with no exemplar labels afterwards: example_duration_bucket{le="5"} 1 # {} 3.0000431 1708975949.123
Desired library implementation:
When presented with a new sample with no exemplar labels the library should retain the existing exemplar so it can be scraped with the metric.
Example of metric after sample is published with an exemplar labels: example_duration_bucket{le="5"} 1 # {traceID="9899898"} 3.0005617 1708951967.457
Example of metric after sample is published with no exemplar labels afterwards: example_duration_bucket{le="5"} 1 # {traceID="9899898"} 3.0005617 1708951967.457
This can probably be done in a backwards compatible manner with an additional flag or something to specifically disable the overriding of exemplars when no exemplar is provided.
prom-client version: 15.1.0
The text was updated successfully, but these errors were encountered:
I have a setup where I only upload a small percentage of my traces.
This means that for majority of my samples in a histogram there won't be a corresponding trace.
Current library implementation:
When presented with a new sample with no exemplar labels the library overrides the bucket's exemplar labels with an empty object essentially purging the existing exemplar
Example of metric after sample is published with an exemplar labels:
example_duration_bucket{le="5"} 1 # {traceID="9899898"} 3.0005617 1708951967.457
Example of metric after sample is published with no exemplar labels afterwards:
example_duration_bucket{le="5"} 1 # {} 3.0000431 1708975949.123
Desired library implementation:
When presented with a new sample with no exemplar labels the library should retain the existing exemplar so it can be scraped with the metric.
Example of metric after sample is published with an exemplar labels:
example_duration_bucket{le="5"} 1 # {traceID="9899898"} 3.0005617 1708951967.457
Example of metric after sample is published with no exemplar labels afterwards:
example_duration_bucket{le="5"} 1 # {traceID="9899898"} 3.0005617 1708951967.457
Example
currently for
prom-client@15.1.0
i'm applying the following hotpatch for Histogram (do not overwrite exemplar values when no exemplar labels given):This can probably be done in a backwards compatible manner with an additional flag or something to specifically disable the overriding of exemplars when no exemplar is provided.
prom-client version: 15.1.0
The text was updated successfully, but these errors were encountered: