Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve bash extension causes shell to exit #28

Merged
merged 1 commit into from Nov 29, 2022

Conversation

ryuma017
Copy link
Contributor

Hi, @siketyan.
I have been using your ghr.
Source code management has become very comfortable. Thank you very much!!!

This PR fixes a small bug that caused the interactive shell to exit when executing commands that fail after installing the bash extension.

$ echo 'eval "$(ghr shell bash)"' >> .bashrc # or other shell config file

$ exec $SHELL -l

$ false # interactive shell exit here

This problem was caused by set -e in resources/shell/ghr.bash, so this line has been removed.
Similarly, set -u has been removed because it may cause problems for some users (as it did for me).

Thank you!

Copy link
Owner

@siketyan siketyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Looks good to me ✌️

@siketyan
Copy link
Owner

It will be shipped in v0.2.3.
This bug is not so critical (for the core of ghr), so we are NOT going to publish any hotfix release for this.
The next release will contain some new features.

Stay tuned!

@siketyan siketyan merged commit 62992dc into siketyan:main Nov 29, 2022
@siketyan
Copy link
Owner

siketyan commented Nov 30, 2022

Correction of the release schedule: This fix has been released in v0.2.3. We have deprecated config.toml files in #31, and removing support in v0.3.0. So we released v0.2.3 as a final release of v0.2, shipped with this bug fix.

Again, thank you for the quick fix @ryuma017 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants