Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semaphore support #52

Closed
seawatts opened this issue Jan 12, 2017 · 1 comment
Closed

Add semaphore support #52

seawatts opened this issue Jan 12, 2017 · 1 comment

Comments

@seawatts
Copy link

It seems like the lock method almost gets you there. However the lock method does not provide a limit which is key for having the semaphore work.

https://www.consul.io/docs/guides/semaphore.html
https://godoc.org/github.com/hashicorp/consul/api#Semaphore

@silas
Copy link
Owner

silas commented Jun 10, 2018

Hey, sorry @seawatts for not getting back to you sooner. I'm probably not going to implement semaphore and I'll probably end up deprecating/removing lock. I haven't had much success creating a good interface for these locking algorithms in node and they add a lot of complexity to the library that very few people actually need.

Thanks for the interest though.

@silas silas closed this as completed Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants