Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes #28

Closed
n7s opened this issue Oct 6, 2021 · 4 comments
Closed

API changes #28

n7s opened this issue Oct 6, 2021 · 4 comments

Comments

@n7s
Copy link
Contributor

n7s commented Oct 6, 2021

SU.utf8char() was deprecated in SILE v0.11.0. Please use luautf8.char() instead.

@devosb
Copy link
Contributor

devosb commented Oct 26, 2021

Where is SU.utf8char() used? I see two occurrences of SU.utf8charfromcodepoint() in classes/fontproof.lua, but not SU.utf8char().

@alerque
Copy link
Member

alerque commented Oct 29, 2021

I also unable to see any usages of this left either in fontproof or SILE itself. I'd be happy to help fix anything that needs it but this seems to be a non-issue. Unless maybe the problem is in SILE itself not being the latest release? I seem to recall this still needs updating to v0.12.0, perhaps the error is being thrown relative to an old version of SILE being used.

@n7s
Copy link
Contributor Author

n7s commented Nov 2, 2021

Sorry, my mistake, it turns out these warnings are coming from fontproof but from the classes shipping inside smith. I can confirm we are running the lastest SILE and fontproof versions. I got confused looking through the logs of our font builds and mixed up the results.

@n7s n7s closed this as completed Nov 2, 2021
@alerque
Copy link
Member

alerque commented Dec 18, 2021

No problem, glad it got tracked down. If you need help porting deprecated bits to new APIs please feel free to ask. I typically test deprecations on my own past projects but that doesn't always catch edge cases where the replacement isn't clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants