Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid mktemp during build, breaks opensuse packaging #1542

Merged
merged 1 commit into from Aug 29, 2022
Merged

Avoid mktemp during build, breaks opensuse packaging #1542

merged 1 commit into from Aug 29, 2022

Conversation

alerque
Copy link
Member

@alerque alerque commented Aug 26, 2022

Fixes #1359

@alerque alerque changed the title chore(build): Avoid mktemp during build, breaks opensuse packaging Avoid mktemp during build, breaks opensuse packaging Aug 26, 2022
@alerque alerque added this to the v0.14.3 milestone Aug 26, 2022
@alerque alerque added the tooling Build tooling, release management, and packaging processes label Aug 26, 2022
@alerque alerque merged commit c6ad2f6 into sile-typesetter:master Aug 29, 2022
@alerque alerque deleted the accomodate-opensuse branch August 29, 2022 19:37
alerque added a commit that referenced this pull request Aug 30, 2022
@alerque
Revert "chore(build): Avoid mktemp during build, breaks opensuse pack…
bca007f 
…aging (#1542)"

This reverts commit c6ad2f6.

The issue on openSUSE turned out to be something else, and the mktemp
solution is just slightly more robust that the per-version filename
thing. It is less likely to reuse parts of an old test or hand generated
file in the event of weird filesystem ACLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoncozens simoncozens Awaiting requested review from simoncozens

Assignees
No one assigned
Labels
tooling Build tooling, release management, and packaging processes
Projects
None yet
Milestone
v0.14.3
Development

Successfully merging this pull request may close these issues.

French special punctuation spaces do not honor current font size
1 participant
@alerque