Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extricate char-def library to ... somewhere #686

Open
alerque opened this issue Oct 17, 2019 · 2 comments
Open

Extricate char-def library to ... somewhere #686

alerque opened this issue Oct 17, 2019 · 2 comments
Labels
refactor Code quality improvements todo

Comments

@alerque
Copy link
Member

alerque commented Oct 17, 2019

In the same spirit as #669 and #670, the char-def blob in lua-libraries can probably go. In it's current format it generates lint errors because of it's global access method but I'm ignoring that for the moment in #168

This data is probably in the Unicode CLDR data set that I'm already abstracting into a Lua Rock of its own and bringing in as part of #665 (will land with PR #675).

@alerque
Copy link
Member Author

alerque commented Oct 29, 2019

So it seems this data is not part of CLDR at all, but actually part of another Unicode data-set called UCD. I'm not sure yet whether than belongs in cldr-lua or on its own somewhere. Just linking that discovery here for whenever I try to deal with this (or when anybody else takes it up).

@simoncozens
Copy link
Member

Char-def was stolen from https://source.contextgarden.net/tex/context/base/mkiv/char-def.lua
Reformatting should be done with a script, and should include re-writing it to be a module which returns its data.

@simoncozens simoncozens self-assigned this Jan 13, 2020
@Omikhleia Omikhleia added the refactor Code quality improvements label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code quality improvements todo
Projects
None yet
Development

No branches or pull requests

3 participants