Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tag for multiple container definitions #84

Closed
vincentkwok opened this issue Jan 20, 2017 · 5 comments
Closed

Replace tag for multiple container definitions #84

vincentkwok opened this issue Jan 20, 2017 · 5 comments

Comments

@vincentkwok
Copy link

vincentkwok commented Jan 20, 2017 •
edited

Right now, it only replaces the first container definition. For those having same tag container group (i.e. it shares the same tag name), it should be replace as well.
@vincentkwok vincentkwok changed the title Replace tag for multiple container definition Replace tag for multiple container definitions Jan 20, 2017
@fillup
Copy link
Contributor

fillup commented Mar 30, 2017

@vincentkwok can you look at PR #94 and see if that is what you are looking for. It replaces the tag for all containers regardless of the image name. So for multi-container definitions where each container shares a tag name this can update them all.

@vincentkwok
Copy link
Author

LGTM. thanks at all

@svperfecta
Copy link

Very nice. We're looking forward to this too.

@svperfecta
Copy link

@fillup Can we merge this by chance? Looking to get the new version from PIP!

@devon-sil
Copy link
Contributor

PR #94 has already been merged in. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@svperfecta @fillup @vincentkwok @devon-sil