Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local version geth to the GitHub CI, update tests #60

Open
Vid201 opened this issue Feb 17, 2023 · 6 comments
Open

Add local version geth to the GitHub CI, update tests #60

Vid201 opened this issue Feb 17, 2023 · 6 comments
Labels
A-test Area: Related to testing good first issue Good for newcomers T-enhancement Type: Enhancement to existing feature

Comments

@Vid201
Copy link
Member

Vid201 commented Feb 17, 2023

Some tests will rely on local geth node, would be useful to have this in github action

@zsluedem
Copy link
Collaborator

Currently, each test would start a geth node by itself. Do you mean start only one and put it in the backgroud?

@Vid201
Copy link
Member Author

Vid201 commented Feb 18, 2023

Yes, that's the idea. A lot of unit tests also need a geth client since several checks depend on that (e.g., https://github.com/Vid201/aa-bundler/blob/main/src/uopool/services/sanity_check.rs#L356).

We could run geth in the background, deploy all necessary contracts (and possibly do other things) before running tests.

@zsluedem
Copy link
Collaborator

I used to have problems with one big Geth dev mode because the rust tests are running in parallel. Then nonce is a little bit tricky.

@Vid201
Copy link
Member Author

Vid201 commented Feb 20, 2023

Hmm, you're right. Ok, then let's leave this for now.

@zsluedem
Copy link
Collaborator

Hm.. Maybe the problem is that I kept using the same wallet to do the test. Instead, we could have a new wallet for each test. In that case , nonce is not the problem.

@Vid201
Copy link
Member Author

Vid201 commented May 9, 2023

Just adding here: update canonical sanity check test to use local geth (relying on some RPC provider is not the best option). We can also enable simulateValidation tests on entrypoint then.

@Vid201 Vid201 changed the title add local geth to github action Add local geth to the GitHub CI and update tests May 19, 2023
@Vid201 Vid201 added the good first issue Good for newcomers label May 19, 2023
@Vid201 Vid201 added A-test Area: Related to testing T-enhancement Type: Enhancement to existing feature labels Dec 11, 2023
@Vid201 Vid201 changed the title Add local geth to the GitHub CI and update tests Add local version geth to the GitHub CI, update tests Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-test Area: Related to testing good first issue Good for newcomers T-enhancement Type: Enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants