-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local version geth to the GitHub CI, update tests #60
Comments
Currently, each test would start a geth node by itself. Do you mean start only one and put it in the backgroud? |
Yes, that's the idea. A lot of unit tests also need a geth client since several checks depend on that (e.g., https://github.com/Vid201/aa-bundler/blob/main/src/uopool/services/sanity_check.rs#L356). We could run geth in the background, deploy all necessary contracts (and possibly do other things) before running tests. |
I used to have problems with one big Geth dev mode because the rust tests are running in parallel. Then |
Hmm, you're right. Ok, then let's leave this for now. |
Hm.. Maybe the problem is that I kept using the same wallet to do the test. Instead, we could have a new wallet for each test. In that case , |
Just adding here: update canonical sanity check test to use local geth (relying on some RPC provider is not the best option). We can also enable simulateValidation tests on entrypoint then. |
Some tests will rely on local geth node, would be useful to have this in github action
The text was updated successfully, but these errors were encountered: