Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cross Validation #6

Open
joshualeond opened this issue Mar 20, 2018 · 1 comment
Open

Feature: Cross Validation #6

joshualeond opened this issue Mar 20, 2018 · 1 comment

Comments

@joshualeond
Copy link

Thanks for open sourcing your work! I just had a comment on the model performance evaluation.

It looks like this package checks the best out-of-sample forecast for the last set of values of test_size. If that's the case then it could be beneficial to include a rolling forecast origin evaluation. Given that the forecast package has the tsCV() function you might be able to use that easily.

I'm sure this would make the model selection process much slower but would probably be more robust. It could just be an option in the select_forecast function.

@sillasgonzaga
Copy link
Owner

Thank you for using this package.

Cross Validation is indeed a very useful resource for forecasting evaluation, so I'll take a look into that, although I'm quite short on time. Please feel free to submit a pull request if you would to be a contributor for the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants