Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement verification fails if ReplacementText contains match group syntax #62

Open
tombogle opened this issue Aug 4, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tombogle
Copy link
Contributor

tombogle commented Aug 4, 2023

Although the code does a Regex.Replace, which should allow for the ReplacementText to specify a regex replacement (e.g., with group numbers or names), the verification code does not consider whether there were any matches but merely checks to see whether the resulting string contains the literal ReplacementText string. If it doesn't, it reports failure and does not save the file.

@tombogle tombogle added the bug Something isn't working label Aug 4, 2023
@tombogle tombogle self-assigned this Aug 4, 2023
tombogle added a commit that referenced this issue Aug 4, 2023
tombogle added a commit that referenced this issue Aug 7, 2023
…ification

#62 Improved FileUpdate replacement verification and error handling (#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant