Skip to content

Commit

Permalink
Ensure features have enough space. Fix from Mozilla
Browse files Browse the repository at this point in the history
  • Loading branch information
mhosken committed Mar 9, 2017
1 parent 348c11e commit 1ce331d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/FeatureMap.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ bool FeatureRef::applyValToFeature(uint32 val, Features & pDest) const
else
if (pDest.m_pMap!=&m_pFace->theSill().theFeatureMap())
return false; //incompatible
pDest.reserve(m_index);
pDest.reserve(m_index+1);
pDest[m_index] &= ~m_mask;
pDest[m_index] |= (uint32(val) << m_bits);
return true;
Expand Down

2 comments on commit 1ce331d

@tim-eves
Copy link
Contributor

@tim-eves tim-eves commented on 1ce331d Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix.

@pgajdos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mhosken and @tim-eves
this is fix for CVE-2017-5436?

Please sign in to comment.