Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Исправлен парсинг фича файла с учетом текста описания сценария #56 #324

Merged
merged 1 commit into from Sep 21, 2018

Conversation

pumbaEO
Copy link
Contributor

@pumbaEO pumbaEO commented Sep 20, 2018

реализация #323

сделанные изменения

При парсинге сценария если находимся в сценарии и нет ключевого слова на следующей строке не останавливаем парсинг, а идем дальше

@silverbulleters/Collaborators - просьба прокомментировать и проверить

@pumbaEO
Copy link
Contributor Author

pumbaEO commented Sep 20, 2018

View it http://f8cced34.ngrok.io/vnc_auto.html for ./features/Core/Translate/

@pumbaEO
Copy link
Contributor Author

pumbaEO commented Sep 20, 2018

View it http://d688177d.ngrok.io/vnc_auto.html for ./features/Core/FeatureReader/

@pumbaEO
Copy link
Contributor Author

pumbaEO commented Sep 20, 2018

View it http://c76dc7e2.ngrok.io/vnc_auto.html for ./features/StepsRunner/

Copy link
Collaborator

@artbear artbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень полезное дополнение

@pumbaEO Добавь, пожалуйста, пример подобной простой фичи с произвольным описанием.

предлагаю в каталоге features\Core\FeatureReader

например, на базе простейшей фичи оттуда
СоседняяФичаСтруктураСценария.feature

@artbear
Copy link
Collaborator

artbear commented Sep 20, 2018

чтобы у нас полезный функционал был автоматически протестирован

@artbear
Copy link
Collaborator

artbear commented Sep 20, 2018

я бы в релиз включил, :)
как раз сегодня хотел его выпустить

@artbear artbear added this to the 5.6.0 milestone Sep 20, 2018
@artbear artbear merged commit efabc08 into develop Sep 21, 2018
@artbear artbear deleted the feature/fixscenariodescription branch September 21, 2018 15:27
@artbear artbear self-assigned this Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants