Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure snippet "<some_tag TAB" can be used #34

Closed
Snakefin opened this issue Sep 20, 2023 · 5 comments
Closed

Make sure snippet "<some_tag TAB" can be used #34

Snakefin opened this issue Sep 20, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Snakefin
Copy link

Describe the bug
When using the Silverfin platform editor, we have certain snippets we can use to create elements in a HTML table.
eg doing '<table' or '<tr' and TAB, will create the correct element.

However, in our CLI, when doing the same, it will actually create an unneeded additional open and closing tag (< and >), this breaking the output of the HTML table.

To Reproduce
Steps to reproduce the behavior:

  1. Use '<tr' and TAB
  2. Check the open and closing tags

You'll see this:

      <<tr>
        <td>
          content
        </td>
      </tr>>

Expected behavior

<tr>
        <td>
          content
        </td>
      </tr>

Screenshots or Pull request

See https://silverfin.slack.com/archives/C0376K9NNTS/p1695196982800949

Desktop & CLI (please complete the following information):

  • OS: macOS (latest version)
  • CLI version (run silverfin --version): 1.18.2
@Snakefin Snakefin added the bug Something isn't working label Sep 20, 2023
@Woetfin
Copy link
Contributor

Woetfin commented Oct 4, 2023

@Snakefin in the current extension, it's enough to just type tr to get the snippet instead of <tr, it's one character less so I don't think it's a problem? The extra <, is added because this isn't needed for the shortcut anymore to get the snippet
Screenshot 2023-10-04 at 13 25 49

@Snakefin
Copy link
Author

Snakefin commented Oct 4, 2023

It's not a problem per sé, but it does break habits of people that are used to our platform editor though. Hence the issue here, as I was expecting all snippets of our platform editor to behave exactly the same in our CLI 😅

Matter of getting used to it, not a biggie ☺️

@Woetfin Woetfin mentioned this issue Mar 21, 2024
@Woetfin
Copy link
Contributor

Woetfin commented Apr 3, 2024

@Snakefin are you used to it already and I can close this? 😄

@Snakefin
Copy link
Author

Snakefin commented Apr 3, 2024

I am indeed used to it by now; clever on your part waiting 😉

@Woetfin
Copy link
Contributor

Woetfin commented Apr 3, 2024

Patience is a virtue 😇

@Woetfin Woetfin closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants