Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #11

Open
1 task done
Stentonian opened this issue Jul 27, 2023 · 7 comments · Fixed by #57
Open
1 task done

Upgrade dependencies #11

Stentonian opened this issue Jul 27, 2023 · 7 comments · Fixed by #57
Labels
blocked No more to do until other task is complete
Milestone

Comments

@Stentonian
Copy link

Stentonian commented Jul 27, 2023

@Stentonian Stentonian added this to the Cleanup milestone Jul 28, 2023
@Stentonian
Copy link
Author

This should be done at the end of the cleanup stage. Reason:

Some of the tests have been turned off because they take too long to run. If we upgrade now (before adjusting the tests) then we may break the tests unknowingly.

@Stentonian
Copy link
Author

Actually we still need to run the cargo command to upgrade the dependencies

@Stentonian Stentonian reopened this Sep 20, 2023
@Stentonian
Copy link
Author

curve25519_dalek_ng VS curve25519_dalek

The former has the following text:

This crate continues the curve25519-dalek series under a different package name. Unfortunately, one of the maintainers of the previous crate seized control of the dalek-cryptography GitHub organization and the subtle and curve25519-dalek crates by silently removing all other co-maintainers.

Relevant: dalek-cryptography/curve25519-dalek#345
Does not seem like there is a legitimate security concern with the original repo.

The former has not been updated in 2 years, but the latter was updated last week.

Going to rather use the original repo.

@Stentonian
Copy link
Author

Turns out you cannot switch from curve25519_dalek_ng to curve25519_dalek without breaking the bulletproofs dependency, because it uses curve25519_dalek_ng

@Stentonian
Copy link
Author

I raised a question on the bulletproofs repo: zkcrypto/bulletproofs#15

@Stentonian Stentonian added the blocked No more to do until other task is complete label Nov 14, 2023
@Stentonian
Copy link
Author

Just waiting on v5 to be published zkcrypto/bulletproofs#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked No more to do until other task is complete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant